relibc: init #475237
Open
relibc: init #475237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderssorby
reviewed
Dec 30, 2025
Anderssorby
reviewed
Dec 30, 2025
Anderssorby
reviewed
Dec 30, 2025
Co-authored-by: =?UTF-8?q?Anders=20Christiansen=20S=C3=B8rby?= <anders@sorby.xyz> Co-authored-by: Boosted-Bonobo <boostedbonobo1@outlook.com>
Member
Author
|
Unfortunately there is no |
niklaskorz
reviewed
Jan 9, 2026
| }: | ||
| rustPlatform.buildRustPackage { | ||
| pname = "relibc"; | ||
| version = "0.2.5"; |
Member
There was a problem hiding this comment.
Suggested change
| version = "0.2.5"; | |
| version = "0.2.5-unstable-2025-12-29"; |
niklaskorz
reviewed
Jan 9, 2026
| patchPhase = '' | ||
| runHook prePatch | ||
|
|
||
| patchShebangs --build renamesyms.sh stripcore.sh |
Member
There was a problem hiding this comment.
This should be done in postPatch instead, as setting patchPhase means the patches attribute won't be applied (although none are set here in the pcakage right now, they could be set through overrideAttrs)
niklaskorz
reviewed
Jan 9, 2026
| runHook preInstall | ||
|
|
||
| mkdir -p $out | ||
| DESTDIR=$out make CC=gcc AR=ar LD=ld NM=nm install |
Member
There was a problem hiding this comment.
Aren't these all set by the stdenv already? (except DESTDIR)
niklaskorz
reviewed
Jan 9, 2026
| buildPhase = '' | ||
| runHook preBuild | ||
|
|
||
| make CC=gcc AR=ar LD=ld NM=nm CARGO_COMMON_FLAGS="" all |
Member
There was a problem hiding this comment.
Same question as for the install phase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redone relibc pr. A lot of issues that involved fetchFromGitLab, cargoLock defined instead we can use cargoHash(vendored), some werid changes to aliases to deprecated packages, staleness, merge conflicts and more.
Closes: #453786
Waiting on #475235 to be merged first before we rebase and merge this one.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.